coreui / coreui-pro / 37199448009

96%

main: 94%

push

github

fix: type-check the options of components that have a config type (#1550)

* fix: type-check the options of components that have a config type

Eighteen components exported a closed config type and still took
`ComponentConfig`, any record, in the constructor, and every component's
getOrCreateInstance did the same, so `new Tooltip(el, { titel: 'Hello' })`
compiled. The constructors of Chip, ChipSet, Combobox, ListBox, Menu,
Popover, Range, RangeSlider, Toast, Toaster, Tooltip and Transfer now take
`Partial<Config>`; SectionInput is generic over its config, so DateInput and
TimeInput take theirs in the constructor and setConfig;
getOrCreateInstance takes whatever the constructor takes.

DatePicker, DateRangePicker, TimePicker and DateRangeInput pass every option
their parts declare on to them, and the docs say so, so their constructors
take their own options plus those of the parts: the calendar, the date or
range input and the time columns. The time columns had an inferred Default
(`hourCycle: null`, `hours: null`), so they get a TimeSelectionConfig written
from their DefaultType. Where two parts type one option differently the
intersection keeps what both accept: a TimePicker's minDate is a date or a
string, because the time columns refuse a number.

consumer.ts checks an unknown option on each of the eighteen constructors, on
getOrCreateInstance and on a field's setConfig, and the forwarded options of
the four composites; the twenty unknown-option cases fail on the old
declarations.

* fix: keep the composite option types to what the parts receive

A composite's type took every option of its parts, including the ones it
always overwrites: a DatePicker's calendar startDate and its time columns'
hourCycle, onChange and time, a TimePicker's field date and roll hourCycle
and onChange, a DateRangePicker's calendar range and selectEndDate. Those
compiled and did nothing, so the types now leave them out, and the docs of
the three pickers name them. DateRang... (continued)

6836 of 7389 branches covered (92.52%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

11995 of 12288 relevant lines covered (97.62%)

1490.33 hits per line