coreui / coreui-pro / 37205537573

96%

main: 94%

push

github

fix: type-check the options of every other component (#1551)

* fix: type-check the options of every other component

Autocomplete, ChipInput, ContextMenu, Dialog, Drawer, Dropdown,
LoadingButton, Modal, MultiSelect, Navigation, Offcanvas, Rating,
SearchButton and Stepper still took any record in the constructor, and
Autocomplete, MultiSelect, Rating and the time columns any value in
setConfig. Each now has a config type, written by hand from its DefaultType
and the docs, exported next to the plugin and taken by the constructor,
getOrCreateInstance and setConfig. DialogBase is generic over its config, so
Dialog and Drawer take theirs without a constructor of their own; ContextMenu
and Dropdown take MenuConfig, which their Default already was. NumberInput
and PasswordInput already took their types and now export them.

The types also take what the runtime converts before it checks: a comma list
for Autocomplete options, a number or a comma list for a MultiSelect value
and a comma list for Rating tooltips. The documented closed sets are closed:
a backdrop is a boolean or 'static', a spinner 'border' or 'grow', a
MultiSelect selection type, indicator and select-all mode their listed
values. The MultiSelect docs listed its value as a boolean; they now give
the types it takes. Components without options (Accordion, Alert, Button,
Progress, Sidebar, Tab) keep taking any record.

consumer.ts checks an unknown option on each of the fourteen constructors and
on the three setConfig, a value outside three of the closed sets, and six of
the fourteen new type exports; the seventeen unknown-option cases fail on the
old declarations, and check-config-types.mjs passes for all 41 components.

* fix: close the remaining documented value sets and give the menus their own types

ContextMenu took MenuConfig, whose placement allows the null a Dropdown
leaves to its markup, but ContextMenu checks placement as a string and threw
on null; it now has a ContextMenuConfig with a... (continued)

6836 of 7389 branches covered (92.52%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 12 files covered. (100.0%)

11995 of 12288 relevant lines covered (97.62%)

1490.29 hits per line