coreui / coreui-pro / 37188509104

96%

main: 94%

push

github

fix(Popup): fire shown once the panel has faded in (#1545)

The popup of the pickers settled `shown` and `hidden` on `transitionend` or
on a timer as long as the transition, started when `show()` or `hide()`
ran. When the main thread was busy right after `show()`, the fade started
only after the busy stretch, together with the overdue timer, so `shown`
fired on a panel still at opacity 0 (measured in Chromium), and the visual
spec that checks it failed under load in the pre-push hook.

The popup now waits for the panel's opacity transition to finish, for
`shown` and `hidden` alike, with a timer of the transition plus one second
as the bound for a document the browser does not render, such as a hidden
tab. Without a transition, or without Web Animations as in jsdom, it keeps
the timer of the transition's length. A fade cut short, as when an ancestor
is hidden, settles at once.

The bundles grow by 38 to 64 B (gzip -9 against v6-dev), and `coreui.js`,
which sat 30 B under its bundlewatch ceiling, breaks it, so that ceiling
goes up by 0.25 kB.

6828 of 7381 branches covered (92.51%)

Branch coverage included in aggregate %.

5 of 8 new or added lines in 1 file covered. (62.5%)

11989 of 12282 relevant lines covered (97.61%)

1490.0 hits per line