coreui / coreui-pro / 37188170432

96%

main: 94%

push

github

fix(DateRangeInput, DatePicker, DateRangePicker, TimePicker): an empty field label takes the composite's default (#1544)

A composite that got an empty section label for its field, such as
`ariaDayLabel: ''` on `DateRangeInput`, `DatePicker` or `TimePicker`, or an
empty end label such as `ariaStartLabel: ''` on `DateRangePicker`, passed
the empty string on, and the field fell back to its own English default
even when the page had localised the composite's `Default`. Such a label now
counts as not given and takes the composite's default first. Other empty
options still pass through as they are, so `ariaNothingToPickLabel: ''`
still leaves the calendar grid undescribed. The forwarding of options to a
part, which `DateRangeInput` and `PickerBase` each wrote out, moves to
`getForwardedOptions` in `util/composite`.

A separator `DateRangeInput` creates went before the end, so with the ends
written end first it landed before both instead of between them; it now
goes between them. Ends wrapped together in one element of the author's
still get the separator before the wrapper, where the disabled frame dims it.

The unminified bundles grow by 477 to 484 B and the minified ones by 128 to
144 B (gzip -9 against v6-dev); `coreui.js`, `coreui.esm.js` and
`coreui.bundle.js` break their bundlewatch ceilings and `coreui.esm.min.js`
is left 30 B under its own, so the four go up by 0.25 kB.

6826 of 7379 branches covered (92.51%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 3 files covered. (100.0%)

11988 of 12280 relevant lines covered (97.62%)

1490.12 hits per line