coreui / coreui-pro / 37160209345

96%

main: 94%

push

github

fix(Calendar, DateInput): read only days and times that exist (#1542)

A date string naming a day its month does not have was read as a day of
the next month: '2/30/2022' became 2 March and '4/31/2022' 1 May, because
the locale patterns checked the day only against 31, and an ISO string such
as '2022-02-30' or a date and time string went to the native parser, which
rolls the day over. `convertToDateObject` now gives `null` for such a day,
and checks the day a string starts with, in ISO order or the locale's,
before handing it to the native parser. A `minDate` or `maxDate` written
that way gives no limit, as an unreadable one already did.

`convertValue` read '24:00' as midnight of the next day and '13:30 pm' as
01:30, and a date and time string took '13:30 AM' as 13:30; a time no clock
shows now gives `null`.

`isDisableDateInRange` walked from the start keeping its time of day, so a
range whose end was later in the day than its start also checked the day
after the end, and a disabled day there refused the range. It now walks
whole days, from the day after the start through the end's day.

`Calendar`, `DateInput` and `TimeInput` take a number for their dates, which
is what a `data-*` attribute such as `data-coreui-start-date="2026"` turns
into; a number is now read as its digits instead of throwing on `trim`, so
a timestamp gives no date.

`coreui.js` grows by 350 B, `coreui.esm.js` by 369 B and `coreui.bundle.js`
by 283 B (gzip -9 against v6-dev), mostly the day check before the native
parser and its JSDoc, so their bundlewatch ceilings go up by 0.25 kB.

6820 of 7373 branches covered (92.5%)

Branch coverage included in aggregate %.

26 of 26 new or added lines in 2 files covered. (100.0%)

11978 of 12270 relevant lines covered (97.62%)

1485.88 hits per line