coreui / coreui-pro / 37134398608

96%

main: 94%

push

github

fix(PasswordInput): put the field's type back on dispose (#1534)

`dispose()` removed the toggle button and released the frame, but left the input's `type` as the toggle had set it. A password the user had revealed stayed readable after the component was gone, and there was no button left to hide it.

The component now keeps the `type` from the markup when it starts and puts it back on `dispose()` (or removes the attribute if the markup had none), but only while the attribute still holds what the toggle last wrote, so a `type` the page set afterwards is left alone. A second `dispose()` now returns early instead of reaching the element the first one cleared. The `dispose()` row of the methods table says so.

React and Vue render the input themselves, so it goes away with the component and they need no change. The change adds 54 B gzip to `coreui.bundle.min.js`, which goes past its ceiling, and 71 B to `coreui.min.js`, which is left 10 B under its own, so both budgets go up by 0.25 kB.

6778 of 7331 branches covered (92.46%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 1 file covered. (100.0%)

11932 of 12225 relevant lines covered (97.6%)

1484.12 hits per line