coreui / coreui-pro / 37134167645

96%

main: 94%

push

github

fix(DateInput): take Backspace and Delete from a virtual keyboard (#1533)

A virtual keyboard, as on Android, sends keydown with the key
"Unidentified" and the real edit in beforeinput. The field read typed
characters from beforeinput but cancelled the deletions, so Backspace
and Delete did nothing on a phone. In an editable field beforeinput now
turns insertText, deleteContentBackward and deleteContentForward into
the keydown a hardware key sends, so a phone keyboard takes the same
path; a read-only field only cancels the edit, so the page never sees a
second keydown for one key. TimeInput and the range ends share the
field and get the same.

The fix adds 95 B gzip to coreui.js, 74 B to coreui.min.js and 56 B to
coreui.bundle.min.js (gzip -9 on both builds). Bundlewatch put
coreui.bundle.min.js over its ceiling and left coreui.js and
coreui.min.js 20 B and 10 B under theirs, so the three budgets go up by
0.25KB: coreui.bundle.min.js to 109.25KB, coreui.js to 160.5KB,
coreui.min.js to 103KB.

6772 of 7325 branches covered (92.45%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

11922 of 12215 relevant lines covered (97.6%)

1485.35 hits per line