coreui / coreui-pro / 37019663823

96%

main: 94%

push

github

fix(forms): keep the success message away from a frame that holds an error (#1520)

The rules that show .valid-feedback and .valid-tooltip for a control group,
next to it and inside a .form-field, outweighed the rules that hide them
while the group holds an invalid control once a .form-floating wrapper sat
in between (0,4,0 against 0,3,0, and 0,5,0 against 0,4,0). A date range
with floating labels, one end valid and the other past maxDate, showed
"Looks good" next to the error. The group and field show rules now keep
their state test inside :where(), at 0,2,0, so the hide rules win for every
wrapper, and also in a flat layout where a valid group's ~ reaches the
feedback of an invalid group after it.

Two gaps of the same kind close with it: a group carrying .is-valid around a
control the browser marks :user-invalid in a validated form, and the
:user-valid rule for an .input-group inside a .form-field, which had no
guard. The change lands in coreui.css, the Bootstrap theme and
components/forms/validation.css; the grid, reboot and utilities builds are
unchanged. The date range input docs say valid skips an end announced
invalid.

6732 of 7284 branches covered (92.42%)

Branch coverage included in aggregate %.

11873 of 12167 relevant lines covered (97.58%)

1479.74 hits per line