coreui / coreui-pro / 37016758573

96%

main: 94%

push

github

fix(DateRangeInput, DateRangePicker): keep the fields from turning valid while the range is reversed (#1519)

* fix(DateRangeInput, DateRangePicker): keep the fields from turning valid while the range is reversed

With the end before the start, the frame carried .is-invalid while both
fields took .is-valid from the valid option or from a validated submit.
The group rule for a valid child outranks the frame's own state, so the
frame was drawn green under the invalid feedback (measured in Chromium:
--cui-control-border-color resolved to the success colour). A field now
draws .is-valid only while neither its range nor the page announces it
invalid (aria-invalid="true"); the range already tells its fields through
_setOwnerInvalid, which now also drops and restores the valid class. The
stylesheet is unchanged: the components decide the state, the CSS shows it.

* fix(DateInput, TimeInput, DateRangeInput): draw no valid state on a field announced invalid

The valid class now follows the aria-invalid the field writes: a field
invalid on its own (a date the limits reject, the invalid option) no longer
carries .is-valid next to .is-invalid when the valid option is set, and a
range frame the markup marks invalid keeps its fields from turning valid as
the reversed order does. Docs say where valid stops forcing the state, and
the date range picker page no longer says the valid option holds whatever
the range is. A visual spec pins the frame colour of a reversed range with
the valid option.

6732 of 7284 branches covered (92.42%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

11873 of 12167 relevant lines covered (97.58%)

1479.72 hits per line