hyperledger-labs / fabric-smart-client / 37001293323

91%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(fabric)!: remove the unused delivery.waitForEventTimeout (#2031)

The channel's delivery.waitForEventTimeout key was parsed but never
read, and delivery.New stored a timeout, fed from
CommitterWaitForEventTimeout, that nothing consulted. Setting the key
had no effect.

The Deliver stream has no read deadline, by design: the peer pushes
blocks when they are committed, and a quiet channel can stay silent
for any length of time. The runReceiver godoc and
docs/configuration.md now say so. The docs also add the missing
delivery.bufferSize and give the actual scope of sleepAfterFailure.

Configs that still set delivery.waitForEventTimeout load as before;
the key is ignored.

Closes #1733

BREAKING CHANGE: delivery.New in platform/fabric/core/generic/delivery
no longer takes a waitForEventTimeout argument, and config.Delivery
no longer has a WaitForEventTimeout field.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

7 of 7 new or added lines in 1 file covered. (100.0%)

7 existing lines in 4 files now uncovered.

29054 of 32035 relevant lines covered (90.69%)

2346.66 hits per line