hyperledger-labs / fabric-smart-client / 37002567494

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(view): release the sub-connection map lock before websocket rejection writes (#2028)

newServerSubConn rejects a new sub-connection with an Err frame when
maxSubConns is reached or the claimed PeerID does not match the TLS
identity. Both branches wrote the frame while holding the connection's
sub-connection map lock, so a peer that stopped reading kept that lock
held for up to writeTimeout. Release the lock before the write, as the
success path does.

Document on multiplexedBaseConn.mu that it is never held across a network
write, and add a regression test for both rejection branches.

Fixes #1994

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

6 existing lines in 3 files now uncovered.

29064 of 32035 relevant lines covered (90.73%)

2333.11 hits per line