hyperledger-labs / fabric-smart-client / 36868487461

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(web): release the HTTP connection on non-200 responses (#1984)

Client.req returned the status error without reading or closing the response body, so every failed CallView, CallViewWithContext or Metrics call left its connection open and the next call opened a new one.

Drain and close the body before returning the error so the transport reuses the keep-alive connection. The drain is capped at 64 KiB so a large error body cannot hold the caller; Close leaves any remainder to the transport, which drains a bounded amount or drops the connection.

A regression test covers both sides of the cap: five failed calls with a small error body share one connection, and an oversized body opens a new connection per call instead of being read in full.

Fixes #1979

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

16 existing lines in 7 files now uncovered.

29098 of 32073 relevant lines covered (90.72%)

2329.07 hits per line