hyperledger-labs / fabric-smart-client / 36866838226

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(view)!: delete only the disposed session and stop on a closed master session (#2022)

A responder session takes its ID from the remote peer's message, and
disposing its context closed every session whose registry key started
with that ID. An empty ID or "m" closed the master session. The P2P
service then read nil from the closed channel and crashed the node in
handleMessage.

SessionFactory.DeleteSessions(ctx, id) becomes DeleteSession(ctx, id,
pkid), which closes the one session registered under that ID and remote
PKID. Context.Dispose passes both for each of its sessions, and
Sessions.GetSessionIDs becomes GetSessionInfos to provide them.
Service.Start returns when the master session closes and drains
in-flight handlers on every exit path.

NewResponderContext identifies the context's session by ID and remote
PKID. The same ID from another party is registered as a separate
session, so the responder replies on it and Dispose deletes it.

Fixes #2002

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

27 of 27 new or added lines in 6 files covered. (100.0%)

131 existing lines in 10 files now uncovered.

28982 of 32071 relevant lines covered (90.37%)

2711.47 hits per line