hyperledger-labs / fabric-smart-client / 36842644528

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): report a failed lazy open on every txVaultReader call (#1948)

setVaultReader declared err as a local, so only the call that ran
once.Do saw the error. Every later call returned nil while db.vr was
still nil, and the nine txVaultReader methods dereference db.vr right
after that check, so the second use of a reader whose lazy open had
failed panicked.

The failed open also left db.release nil: the open returns nil, nil,
err, and once.Do assigned all three results. Done then panicked, and
callers defer Done on every reader they obtain.

NewTxLockVaultReader returns successfully even when the open will fail,
because the open is deferred until first use, so a caller cannot detect
the problem before reading.

Store the error on the struct and assign vr and release only when the
open succeeds, so a failed reader keeps its no-op release. The write
happens inside once.Do and every read follows it, so the existing Once
provides the ordering.

TestTxVaultReader_LazyOpenFailurePropagates calls each of the nine
methods twice and then Done, on a reader whose open fails.

Fixes #1925

Signed-off-by: Siddhi Khandelwal <siddhi.200727@gmail.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Co-authored-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

8 of 8 new or added lines in 1 file covered. (100.0%)

7 existing lines in 3 files now uncovered.

29090 of 32063 relevant lines covered (90.73%)

2328.59 hits per line