coreui / coreui-pro / 36847430583

96%

main: 94%

push

github

refactor(Range, RangeSlider)!: multiple thumbs and the vertical range belong to RangeSlider (#1505)

* refactor(Range, RangeSlider)!: multiple thumbs and the vertical range belong to RangeSlider

Range handles the first .form-range-input of its wrapper: the fill, the
tooltip, ticks from its options and a datalist, aria-valuetext from a tick
label and the form reset. distance, clickableTicks, the press on the track
and the vertical orientation are gone from it.

RangeSlider builds the .form-range with one input per value and runs the
multi-thumb engine on util/range itself: the order and distance of the
thumbs, their stacking, the press on the track and on clickable ticks, the
arrow keys of a vertical slider, the band and the form reset. ariaLabels is
ariaLabel, an array or a function of the index and the total.

The stacked-thumb, vertical and clickable-tick rules move from
forms/_form-range.scss to _range-slider.scss, in the forms layer, with the
same classes; the range-slider stylesheet now requires forms/form-range.
util/range gains the tick and tooltip builders and the aria-valuetext text
that both plugins use.

* build: raise the unminified JS budgets for the range slider engine

Measured with gzip -9 against v6-dev at d86f5e6ab: coreui.bundle.js
+642 B, coreui.esm.js +700 B, coreui.js +641 B, the JSDoc of the six util
functions both range plugins now share, which the unminified bundles keep.
The minified bundles change by -18 to +6 B.

* fix(Range, RangeSlider): keep the Range data API off a range slider

A range slider built before DOMContentLoaded matched the Range data API,
which put a second Range on its wrapper and collapsed the band to the first
handle. The data API now skips a .form-range whose parent holds a range
slider. Ticks are clickable only while a handle is enabled, a fieldset
included; ariaLabel also takes a string, comma separated for several
handles, so a string no longer throws in the data API loop; and
Range#update() does not... (continued)

6638 of 7192 branches covered (92.3%)

Branch coverage included in aggregate %.

282 of 287 new or added lines in 3 files covered. (98.26%)

11777 of 12072 relevant lines covered (97.56%)

1004.35 hits per line