coreui / coreui-pro / 36845623520

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(DatePicker): bound the time on the day of a minDate or maxDate with a time of day (#1504)

With `timepicker`, a `minDate` of 15 October 10:00 disabled 15 October in the calendar while the field accepted 08:00 that day, because the picker widened both limits to whole days. The calendar now compares the limits by the day, and on the day of a limit the time selects disable the hours, minutes and seconds that lie beyond it. A time the panel sets beyond a limit (the current time when that day is picked, or an hour whose minutes cross it) moves to the limit, and a typed time beyond it marks the field invalid. Keeping the out-of-range time, as MUI X and React Aria do, does not work here: the field reports no date for it, so the picked day was lost. Until a date is picked the time selects work on today moved into the limits, and a limit without a time of day still covers its whole day.

The field's limit check moves into `getDateLimitError`, which the section input and `isDateSelectableWithin` share. It compares at the field's precision, so a date field compares by the day and a field without seconds can hold the minute of `minDate: new Date()`. The JS budgets go up to fit the measured growth (gzip-size against v6-dev): 1410 B on coreui.bundle.js and 538 B on its minified build.

Coverage Stats

6606 of 7156 branches covered (92.31%)

Branch coverage included in aggregate %.

71 of 71 new or added lines in 7 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

11735 of 12029 relevant lines covered (97.56%)

1009.47 hits per line