coreui / coreui-pro / 36793713050

96%

main: 94%

push

github

fix(Autocomplete): let Enter submit the form and follow a form reset (#1497)

Enter on the autocomplete field always cancelled the keydown and, with the list closed, opened the list, so a form around an autocomplete could not be submitted from the keyboard. With the list closed, Enter from the input now commits the typed text and lets the form submit; the list opens on Arrow Down, and Enter still opens it from the frame itself (a new `_isOpenKey()` hook in `ComboboxBase`, MultiSelect unchanged). With `allowOnlyDefinedOptions`, Enter on text that names no enabled option keeps the text and does not submit. Enter on text that already names the selected option does not fire change again, and Enter that confirms an input method composition is left alone.

The hint input gets an empty `form` attribute. Without it the hint counted as a second text field in the form, which is enough for the browser to skip implicit submission on Enter.

A form reset brings the autocomplete back to the `value` it was created with (or the first option marked `selected`), or to an empty field, and fires `change.coreui.autocomplete` when that differs from what the field held, typed text included. A search in progress restarts through the input event; when the initial value is not among the current options, the reset reports the cleared field and then the value once external results bring it back. A reset that a listener cancels changes nothing.

The same change goes to React and Vue in coreui-react-pro and coreui-vue-pro on the same branch name. The six JavaScript bundle budgets go up, coreui.bundle.js by 0.5 kB and the others by 0.25 kB; the growth is 278 to 362 B gzip per bundle.

6483 of 7033 branches covered (92.18%)

Branch coverage included in aggregate %.

57 of 58 new or added lines in 2 files covered. (98.28%)

11634 of 11933 relevant lines covered (97.49%)

928.53 hits per line