coreui / coreui-pro / 36797389539

96%

main: 94%

push

github

fix(Autocomplete): keep validation classes from the markup and show the default empty text (#1499)

Construction toggled `is-invalid` and `is-valid` from the `invalid` and `valid` options, which default to false, so a class written in the markup, such as a server-side verdict, was removed as soon as the autocomplete started, and dispose() removed both classes whatever their origin. A class from the markup now stays while the field holds the value it started with, including an initial `value` that arrives with later options, the rule DateRangeInput follows for its range. The component removes only the classes it put on or took over from the markup, so a class the page adds later stays, and dispose() gives the markup classes back only while their value is still in the field. setConfig() now applies `invalid` and `valid`, which it ignored, and the input carries `aria-invalid` whenever the frame has `is-invalid`.

`searchNoResultsLabel: true` showed the text "true"; it now shows "No results found". Hints and Tab skip disabled options, and Tab takes an option only while a hint is shown, not after Escape or a click outside dismissed it.

React and Vue fix the hint for grouped options in coreui-react-pro and coreui-vue-pro on the same branch name. The six JavaScript bundle budgets go up, coreui.js by 0.5 kB and the others by 0.25 kB; the growth is 264 to 373 B gzip per bundle.

6507 of 7058 branches covered (92.19%)

Branch coverage included in aggregate %.

46 of 46 new or added lines in 1 file covered. (100.0%)

11667 of 11966 relevant lines covered (97.5%)

929.1 hits per line