coreui / coreui-pro / 36761701564

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(NumberInput): disable the buttons with the field and keep the focus in it (#1492)

Both stepper buttons are now disabled while the input is `disabled` or
`readonly`, and a MutationObserver keeps them in step when a script
changes either attribute, or `min`, `max` or `step`, later.
increment()/decrement() check `:disabled`, so a field inside a disabled
fieldset is not stepped either.

A mouse press on a button, enabled or not, keeps the focus in the field
and moves it there when it is elsewhere, so typing and the arrow keys act
on the field just stepped. The press is handled on the frame, because a
disabled button (`pointer-events: none`) lets it through to the frame; a
touch press is left to the browser. Checked in Chromium, Firefox and
WebKit with the stylesheet loaded.

The change adds 176 to 214 B gzip per JavaScript bundle. coreui.js and
coreui.esm.min.js were already over their ceilings at the base, so all six
budgets go up by 0.25 kB, and coreui.js, coreui.esm.min.js,
coreui.bundle.min.js and coreui.esm.js by another 0.25 kB.

Coverage Stats

6435 of 6985 branches covered (92.13%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

11567 of 11865 relevant lines covered (97.49%)

908.16 hits per line