coreui / coreui-pro / 36757177244

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(NumberInput): step like the browser and stop where the step stops (#1490)

On an empty field the buttons wrote `min`, or `0` without looking at
`max`, whatever the direction: with `min="-10"` both gave -10, with
`max="-5"` both gave 0, which fails validation, and with `step="5"` the
first click only wrote 0. They now go through stepUp()/stepDown(), which
start an empty field from zero and keep it within `min`, `max` and the
step grid; where WebKit leaves the field empty, they step the other way,
and with `min` above `max` nothing happens.

A step is taken, and a button enabled, only when the step changes the
number, tried on a detached copy of the input: "+" is off at the last
value the grid reaches below `max` (9 with `min="0" max="10" step="3"`)
and at `value="10.0"` with `max="10"`. `step="any"` is matched
case-insensitively, never moves a value outside the range against the
direction and does not drift. The click that ends a held button is the
only one skipped, and a hold stops once its step no longer moves the
value.

The buttons give the same value in Chromium, Firefox and WebKit.

Coverage Stats

6426 of 6975 branches covered (92.13%)

Branch coverage included in aggregate %.

36 of 36 new or added lines in 1 file covered. (100.0%)

6 existing lines in 1 file now uncovered.

11554 of 11850 relevant lines covered (97.5%)

908.6 hits per line