coreui / coreui-pro / 36724877372

96%

main: 94%

push

github

fix(SearchButton): stop key presses from bringing a disposed instance back (#1481)

* fix(SearchButton): stop key presses from bringing a disposed instance back

The keydown, keyup and window blur data-API handlers called
getOrCreateInstance for every [data-coreui-search-button] in the document,
so dispose() only lasted until the next key press. They now look the
instance up with getInstance and skip buttons that have none, so the loop
keeps its document order and its attribute gate and never creates an
instance.

Buttons in the document at DOMContentLoaded are still initialised by the
data API, and activating a button (a click, or Enter or Space on it) still
creates its instance. A button inserted later, or one on a page whose
script runs after DOMContentLoaded, needs getOrCreateInstance() before its
shortcut responds; until now the key handlers covered those cases by
accident.

dispose() now takes back the shortcut keys it rendered: the container is
removed when the component created it, and a container written in the
markup gets its own content back. A second dispose() leaves the markup
alone.

The five specs that dispatched a key on a never initialised button now
create the instance first.

* chore: raise the coreui.js and coreui.min.js budgets

The SearchButton fix adds 67 B to coreui.js and 59 B to coreui.min.js
(gzip-size, the measure bundlewatch applies; b7256a0c5 against b15ad4a21).
That leaves coreui.js 2 B and coreui.min.js 14 B under their ceilings, so
both go up by 0.25 KB before the next change runs into them.

6351 of 6902 branches covered (92.02%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 1 file covered. (100.0%)

11445 of 11756 relevant lines covered (97.35%)

880.0 hits per line