coreui / coreui-pro / 36724937020

96%

main: 94%

push

github

fix(Toaster): announce every toast, replace a closing toast, keep limited toasts hidden (#1482)

* fix(Toaster): announce every toast, reuse no closing toast, keep limited toasts hidden

Five defects in the toaster, each reproduced by a spec that failed
before this change:

- Toasts raised in the same frame overwrote each other's announcement:
  each priority's live region held one text node that every toast
  replaced. Every toast now appends its own message node, an update
  replaces that toast's node and removal drops it; the regions lose
  aria-atomic so a new message does not re-read the old ones.
- add() with the id of a toast that was closing rewrote the leaving
  toast, which then disappeared with the new content. A closing toast
  is no longer reused: the same id shows a new toast, and the old
  one's removal no longer deletes the new entry from the store.
- close() on a limited toast forced display: block on it through the
  collapse, and removing a sibling re-released a leaving limited toast.
  A limited toast is no longer collapsed when it closes, and the limit
  counts only toasts that stay.
- The action click was an un-namespaced delegated listener that stayed
  in the event registry with the removed toast. It is namespaced and
  the toaster removes it with the toast.
- promise() settling after dispose() read the disposed config and
  threw an unhandled rejection. The continuation now returns when the
  toaster is gone.

Also: a new ariaCloseLabel option (default 'Close') names every close
button, since the toaster owns that markup and the label could not be
translated, and a class option with extra whitespace no longer throws.

* chore: raise the JS budgets for the Toaster fixes

The Toaster fixes add 120-155 B gzip to every JS bundle (zlib level 9,
base against branch): coreui.js +152 B, coreui.min.js +120 B,
coreui.esm.js +154 B, coreui.esm.min.js +123 B, coreui.bundle.js
+155 B, coreui.bundle.min.js +124 B. coreui.js and coreui.min.j... (continued)

6371 of 6921 branches covered (92.05%)

Branch coverage included in aggregate %.

43 of 43 new or added lines in 1 file covered. (100.0%)

11473 of 11783 relevant lines covered (97.37%)

881.14 hits per line