coreui / coreui-pro / 36715340923

96%

main: 94%

push

github

fix(Calendar): judge month, quarter and year limits by the whole period (#1478)

Measured in Chromium on v6-dev, in month, quarter and year selection:

- A month the limit falls within was drawn as selectable, but a click
  left the date picker empty, because the click, the hover and the
  field checked the first day of the month (minDate 15.10: October;
  disabled weekends: November, which starts on a Sunday). Typing
  10/2026 marked the field invalid.
- A minDate with a time on the last day of a period disabled the whole
  period whenever disabledDates was set, which the vanilla calendar
  always does (minDate 31.10 09:00: October; 31.12 09:00: the fourth
  quarter and 2026, where the quarter grid had no cell left for the
  tab stop).
- A range of months was cleared at the first disabled day it spanned,
  so with weekends disabled September to December could not be picked.

A period can now be picked unless it lies wholly before minDate or
after maxDate, or disabledDates covers every day of it that the limits
leave. The cell, the click, the hover, the keyboard walk and the field
ask that same question, and a range is cleared only when it spans a
period that disabledDates covers wholly. Day and week selection keep
judging a day by its date.

- isCellDisabled() in util/calendar judges a day by its date and a
  period as a whole; the calendar uses it for clicks and hovers, and
  the keyboard walk calls it instead of its own copy of the rule.
- isEveryDayDisabled() walks from the day of minDate to the day of
  maxDate, times of day aside, so neither limit day is skipped.
- isDisableDateInRange() takes the view and, outside the days view,
  counts a day only when its whole period is disabled.
- getLayoutPeriod() in util/date-sections names the period of a field
  without a day or a week; the field moves minDate to the start of that
  period and checks disabledDates on the days the limits leave.
- The calendar and date picker pages describe the rule.

Mea... (continued)

6341 of 6892 branches covered (92.01%)

Branch coverage included in aggregate %.

29 of 29 new or added lines in 4 files covered. (100.0%)

11426 of 11740 relevant lines covered (97.33%)

878.28 hits per line