coreui / coreui-pro / 36714258109

96%

main: 94%

push

github

fix(css): require what the plugins render in the component manifest (#1479)

Five entries of css/components/manifest.json missed stylesheets their
plugins render into:

- forms/chip-input: chip, forms/form-control, forms/form-control-group
- forms/form-date-time: forms/floating-labels, forms/form-control,
  forms/form-control-group, for the control group the date range
  input builds, with floating labels when asked
- forms/number-input: forms/form-control, forms/form-control-group
- rating: tooltip, for the tooltips option
- toaster: buttons and close, for the action and close buttons

Measured in Chromium with the bundled plugins: base.css plus each
entry's closure now matches coreui.css for the chip input (docs markup
and a chip typed by the user), the date range input with and without
floating labels, the number input, the rating tooltip and a toast with
an action. Before, seven of those cases differed. No other entry's
closure changes.

The class ownership check in check-css-components.mjs skipped every
plugin whose file name differs from its manifest entry (range,
chip-input, the date fields, number-input and 14 more) and read classes
only from CLASS_NAME_* constants. It now takes the plugins from
js/src/index.ts, maps each file to its entry, also reads classes the
plugin file writes as literals, and checks the plugins a component
instantiates. A plugin with no entry fails the check. Three pairs are
listed as inert with the reason: .btn-sm on the calendar navigation
buttons, which read none of its tokens, and .form-floating in the chip,
number and password inputs, which never render a floating label.
Removing any of the new edges, or the Range edge from #1477, makes the
check fail.

6320 of 6871 branches covered (91.98%)

Branch coverage included in aggregate %.

11412 of 11726 relevant lines covered (97.32%)

870.87 hits per line