coreui / coreui-pro / 36710358530

96%

main: 94%

push

github

fix(Combobox): give the page back its markup on dispose (#1474)

* fix(Combobox): give the page back its markup on dispose

dispose() only stripped the class and aria-hidden from the caret the plugin had drawn, so every new instance on the same button added another chevron (three after three cycles). It also left the value element, the search field and a panel it had built, the combobox-toggle class and type="button" on the toggle, the combobox-popup class, generated id and inline position and width on a page panel, and two listeners that threw on a re-init over a page panel: the change listener ComboboxBase adds without a reference, on every selection, and the Tab listener on a page search field.

The plugin now records what it creates and what it changes, and dispose undoes only that. It removes the nodes it created (caret, value element, search field, the panel or the parts of it the markup lacked) and gives the toggle back the aria-activedescendant, aria-controls, aria-expanded, aria-haspopup and type the markup had. The combobox-toggle and disabled classes and the disabled attribute come off only when the plugin put them there, so a toggle the page disabled after init stays disabled and one disabled through the config comes back enabled. A page panel loses only the combobox-popup and show classes and gets back the left, min-width, position and top it had inline, keeping whatever the page set on it since; a generated list id goes. A value element the page owns gets its content and placeholder class back. ComboboxBase keeps the change listener and removes it with the list box, which MultiSelect and Autocomplete share. A second dispose returns early, and the docs say what dispose removes.

In Chromium, removeAttribute('style') after unread inline style changes brings the attribute back empty; the panel's style is read before it is dropped, which keeps it removed.

The options keep the role, ids and selected state ListBox gives them; that is ListBox'... (continued)

6320 of 6871 branches covered (91.98%)

Branch coverage included in aggregate %.

59 of 59 new or added lines in 2 files covered. (100.0%)

11412 of 11726 relevant lines covered (97.32%)

870.95 hits per line