hyperledger-labs / fabric-smart-client / 36706684648

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(config, web): parse byte sizes in base 10, catch shift overflow, match websocket upgrades case-insensitively (#1968)

byteSizeDecodeHook parsed the digits with base 0, so a leading zero
switched to octal ("010k" decoded to 8192). It also shifted before the
uint32 range check, so a value whose shift overflowed uint64 wrapped
silently ("18014398509481984g" decoded to 0). The digits are now parsed
in base 10 and the range is checked against MaxUint32 >> shift before
shifting.

HttpHandler compared the Upgrade header to "websocket" case-sensitively,
so after a view upgraded a request with "Upgrade: WebSocket" it still
wrote a JSON body to the hijacked connection. It now uses
websocket.IsWebSocketUpgrade, which matches the Connection and Upgrade
tokens case-insensitively as RFC 6455 requires.

Fixes #1966

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

10 of 10 new or added lines in 2 files covered. (100.0%)

6 existing lines in 2 files now uncovered.

28727 of 32112 relevant lines covered (89.46%)

2755.22 hits per line