hyperledger-labs / fabric-smart-client / 36703460419

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabricx): record a read of a missing key in the vault RWSet (#1963)

GetState returned nil for a key the query service did not have, but
added nothing to the read set and pinned no namespace version. A
transaction that checked a key was free before creating it therefore
carried no dependency on the key's absence: the create serialized as a
blind write, IsValid could not see a concurrent creation, and the
committer accepted both transactions.

A miss is now recorded as a read with a nil version, as the generic
Interceptor does. The namespace version is pinned as for any other read.
The read serializes as a versionless Read, or as a versionless ReadWrite
when the key is also written, so the committer rejects the transaction
if the key exists by then. IsValid reports the key as changed once it
exists, and reading it again returns an error.

Fixes #1962

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

9 of 9 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

28727 of 32117 relevant lines covered (89.44%)

2785.25 hits per line