hyperledger-labs / fabric-smart-client / 36693890463

91%

Build Type

push

github

Committed by web-flow

Commit Message

test(fabric): increase coverage of platform/fabric/core/msp (#1956)

* test(fabric): increase coverage of platform/fabric/core/msp

Cover the idemix MSP wrappers, the MSP manager, config loading by type,
setup stage failures, OU validation, principal matching, IsWellFormed
and the certification chain helpers. Package coverage goes from 83.6%
to 93.3%.

getMspConfig and GetLocalMspConfig returned a nil config and a nil
error when cacerts or signcerts existed but held no PEM content; they
now return an error.

Fixes #1934

Signed-off-by: Said Altury <Said.Altury@ibm.com>

* fix(fabric): reject an empty signcerts directory in LoadLocalMSPSignerCert

LoadLocalMSPSignerCert returned a nil certificate and a nil error when
the signcerts directory existed but held no PEM content; it now returns
an error.

Refs #1934

Signed-off-by: Said Altury <Said.Altury@ibm.com>

---------

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

12 of 12 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

28569 of 32235 relevant lines covered (88.63%)

2713.1 hits per line