hyperledger-labs / fabric-smart-client / 36685808103

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(kvs): report scan errors from the GetByPartialCompositeID iterator (#1946)

The Iterator returned by GetByPartialCompositeID treated a failure of the
underlying store iterator as the end of the scan: HasNext returned false
and dropped the error, so callers could not tell a failed scan from a
complete one and worked with truncated results. Next also dereferenced
a nil state when called before HasNext or after HasNext returned false,
crashing the process.

When a read fails, HasNext now returns true and the following Next
returns the failure, wrapped. The usual loop that stops on the first
error from Next therefore receives it without any change to the Iterator
interface, which keeps existing implementations valid. Iteration ends
after a failure and the store iterator is not read again. Next returns
an error when there is no current state. A caller that ignores the error
from Next now sees one extra iteration with an empty key.

Godoc on Iterator and GetByPartialCompositeID documents the iteration
contract, error reporting, and the requirement to call Close.

Fixes #1945

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

19 of 19 new or added lines in 1 file covered. (100.0%)

13 existing lines in 5 files now uncovered.

28377 of 32226 relevant lines covered (88.06%)

2208.5 hits per line