hyperledger-labs / fabric-smart-client / 36695242674

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabricx): reject RWSet bytes that carry unknown protobuf fields (#1953)

Marshaller.Append decoded its input with proto.Unmarshal, which keeps
fields the schema does not define as unknown fields instead of failing.
The bytes of an unrelated message, such as a marshalled ChannelHeader,
therefore decoded as an applicationpb.Tx without namespaces, and
NewRWSetFromBytes, InspectRWSet and AppendRWSet returned an empty RWSet
with no error.

Append now walks the decoded Tx and rejects it if any message in it
carries unknown fields. The vault rebuilds the serialized form from its
own ReadWriteSet, which cannot hold such fields, so accepting them would
also change the bytes the endorsement covers. Empty input is still
accepted, because it is the serialization of an RWSet without
namespaces.

A foreign message whose wire form happens to be valid for the Tx schema
cannot be told apart from a transaction and is still accepted.

Fixes #1950

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

18 of 18 new or added lines in 1 file covered. (100.0%)

13 existing lines in 4 files now uncovered.

28582 of 32252 relevant lines covered (88.62%)

2224.42 hits per line