hyperledger-labs / fabric-smart-client / 36685234904

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(kvs): stop GetExisting and SplitCompositeKey from panicking (#1944)

GetExisting kept reading from the store iterator while the iterator
returned an error, and dereferenced the returned item to evict its key
from the cache. An iterator that returns a nil item with an error, as
the iterators.Iterator contract allows, crashed the process. The
iterator was also never closed. GetExisting now stops at the first
error, returns the ids found so far, and closes the iterator. Ids read
before the error stay cached, and the remaining ids are queried again
on the next call. Godoc on GetExisting and Exists describes this
best-effort behavior.

SplitCompositeKey panicked with a slice bounds error on any key without
a component separator, such as an empty string. It now returns an error
for keys that do not start with the composite key namespace or have no
components.

Fixes #1456

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Co-authored-by: Said Altury <109276519+SaidAltury-ibm@users.noreply.github.com>

Coverage Stats

13 of 13 new or added lines in 2 files covered. (100.0%)

9 existing lines in 4 files now uncovered.

28366 of 32213 relevant lines covered (88.06%)

2686.48 hits per line