hyperledger-labs / fabric-smart-client / 36642817344

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabricx)!: validate envelopes in the rwset loader and cover it with tests (#1951)

Add unit tests for platform/fabricx/core/transaction/rwset, which had
none. They cover NewLoader, AddHandlerProvider, GetRWSetFromEvn,
GetRWSetFromETx, GetInspectingRWSetFromEvn, anyKeyContains and the
processedTransaction accessors. Fixtures use a real fabricx vault, so
envelopes carry real serialized RWSets, and malformed envelopes are
exercised at each parse depth. The package reaches 100% statement
coverage.

The tests surfaced three defects in the loader, fixed here:
- GetRWSetFromEvn dropped the LoadEnvelope error; it is now wrapped.
- GetInspectingRWSetFromEvn checked neither the txID nor the channel of
  the envelope and reported the caller's txID. Both envelope methods now
  share one check: the header type must be HeaderType_MESSAGE, and the
  channel header must carry the requested txID and the loader's channel.
- AddHandlerProvider stored handlers that nothing consulted. The loader
  decodes fabricx envelopes itself, so AddHandlerProvider is a no-op.

A related defect in the vault marshaller, which decodes non-transaction
bytes as an empty RWSet, is tracked in #1950.

BREAKING CHANGE: the fabricx rwset.Loader rejects envelopes whose header
type is not HeaderType_MESSAGE, or whose channel header names another
channel (both envelope methods) or another txID
(GetInspectingRWSetFromEvn). AddHandlerProvider no longer returns an
error for a duplicate registration, and the handler provider is never
invoked.

Fixes #1828

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Co-authored-by: Said Altury <109276519+SaidAltury-ibm@users.noreply.github.com>

Coverage Stats

18 of 18 new or added lines in 1 file covered. (100.0%)

18 existing lines in 7 files now uncovered.

28353 of 32204 relevant lines covered (88.04%)

2331.16 hits per line