hyperledger-labs / fabric-smart-client / 36641285619

92%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(id)!: remove unused admin identities from id.Provider (#1947)

id.Provider had an admins field that was never populated: no
configuration key loads it and Admins() always returned nil. The gRPC
view service's AccessControlChecker treated admins exactly like
clients, so the concept had no distinct semantics. Remove the field,
the Admins() method, and the Admins() member of the view service's
IdentityProvider interface.

Add unit tests for AccessControlChecker.Check, which had none: the
default and client identities are accepted, unknown creators are
rejected with ErrIdentityNotRecognized before any signature check, and
verifier lookup and signature failures are reported. Document in
docs/configuration.md that the gRPC view service accepts the node's
default identity in addition to fsc.client.certs.

BREAKING CHANGE: (*id.Provider).Admins() and the Admins() method of
server.IdentityProvider are removed. Implementations of the interface
must drop the method; callers should use Clients().

Fixes #860

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

5 existing lines in 3 files now uncovered.

28255 of 32197 relevant lines covered (87.76%)

2805.04 hits per line