hyperledger / fabric-x-committer / 36525669342

91%

Build Type

push

github

Committed by web-flow

Commit Message

[sidecar] Back a block's decoded transactions with one allocation (#833)

#### Type of change

- Improvement (improvement to code, performance, etc)
- Test update

#### Description

- `serialization.UnmarshalTxInto` unmarshals into a caller-provided TX.
`UnmarshalTx` now
  delegates to it, so there is one implementation.
- `mapBlock` carries a third per-block slab for the decoded TXs,
alongside the ones it already
  has for `TxRef` and `TxWithRef`.
- All three slab fields are renamed to `refSlab` / `txWithRefSlab` /
`txSlab`. Without it the new
field would be `blockMapper.txs`, one character from the
`blockWithStatus.txs` that
`appendTx` and `rejectTx` write on adjacent lines — a different type at
a different struct
  depth, which compiles either way.
- Adds the tests `utils/serialization` was missing, including one that
pins what the slab
depends on: `proto.Unmarshal` resets its destination, so a reused entry
is replaced rather
than merged into. Two transactions silently merging is the failure this
rules out.

#### Related issues

- resolves #788

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

19 of 19 new or added lines in 2 files covered. (100.0%)

33 existing lines in 12 files now uncovered.

9530 of 10531 relevant lines covered (90.49%)

10544.77 hits per line