hyperledger / fabric-x-committer / 36525890411

91%

Build Type

push

github

Committed by web-flow

Commit Message

[config] Stop registering defaults inside lists (#838)

#### Type of change

- Bug fix
- Breaking change
- Test update

#### Description

- Splits `setDefaultsAndEnv` into two independent walks,
`registerDefaults` and
  `applyEnvOverrides`, called one after the other.
- `registerDefaults` does not walk into lists, so it no longer registers
`default` tags for the
  fields of list items; `applyEnvOverrides` still does.
- Removes the `"host:port"` string form of `serve.ServerConfig`
(`serverDecoder`); a server
  must be written as a map.
- The development skill notes that a default a list item needs must be
resolved in code.

#### Related issues

- resolves #837

Signed-off-by: Liran Funaro <liran.funaro@gmail.com>

Coverage Stats

33 of 33 new or added lines in 3 files covered. (100.0%)

11 existing lines in 2 files now uncovered.

9539 of 10532 relevant lines covered (90.57%)

11544.04 hits per line