coreui / coreui-pro / 36436403009

96%

main: 94%

push

github

fix: move a picker's aria attributes to the field that uses them (#1465)

An aria-label or aria-describedby on a DatePicker or TimePicker element
stayed on that element, which has no role, so a screen reader never
announced it, and an aria-describedby on a DateRangeInput or
DateRangePicker group reached no field, so the rule that reads the
description on the first section, and on every section of an invalid
field, did nothing there. The pickers now move aria-label,
aria-labelledby and aria-describedby from their element to the field
and give them back on dispose. The field then takes its name the way
the browser ranks names, so an aria-labelledby wins over an aria-label,
a floating label and an ariaLabel in inputOptions, as in React and Vue;
this replaces the exceptions the aria-labelledby forwarding had for
those and for a role on the picker element. A field the author wrote
keeps a name of its own, and an aria-describedby of its own comes
first, followed by the one that moves; the range input and the range
picker add their aria-describedby to both fields the same way. Measured
in Chromium, a date picker field reads its label and "Weekdays only" as
its description. _writeAdoptedAttribute also records a removal, and the
range input restores only what the page has not changed since.

The change adds 205 to 271 B gzip across the six bundles against
v6-dev, measured with gzip at level 9 on a clean base build. That takes
coreui.bundle.min.js, coreui.esm.min.js and coreui.js over their
ceilings and leaves the other three 30 to 70 B under theirs, so all six
get 0.25 kB more.

6266 of 6821 branches covered (91.86%)

Branch coverage included in aggregate %.

35 of 35 new or added lines in 5 files covered. (100.0%)

11324 of 11641 relevant lines covered (97.28%)

860.31 hits per line