coreui / coreui-pro / 36431002914

96%

main: 94%

push

github

fix: let a visible label name the picker and range fields (#1464)

A label next to a date picker, time picker, date range input or date
range picker had no way to name the field: the pickers build their
field themselves, and the range elements carried no role, so an
aria-labelledby on them named nothing. DateRangeInput and
DateRangePicker now make their element a role="group" unless it carries
a role of its own, so an aria-labelledby there names the pair of
fields, which keep "Start date" and "End date"; the range picker's
inner frame is role="none", so the pair is not wrapped twice.
DatePicker and TimePicker pass the aria-labelledby on their element on
to the field unless the field already has a name (a floatingLabel, an
ariaLabel in inputOptions, or an aria-label or aria-labelledby on a
field the author wrote) or the picker element carries a role of its
own. Measured in Chromium, the fields read "Delivery date" and "Opening
time" and the pairs "Stay" and "Reporting period", and the 28 examples
on those pages point aria-labelledby at their label.

The change adds 172 B gzip to coreui.bundle.js and coreui.js, 158 B to
coreui.esm.js and 109 to 110 B to the minified bundles against v6-dev,
measured with gzip at level 9 on a clean base build. That takes
coreui.min.js and coreui.js over their ceilings and leaves
coreui.bundle.js and coreui.esm.js 40 to 60 B under theirs, so all four
get 0.25 kB more.

6250 of 6805 branches covered (91.84%)

Branch coverage included in aggregate %.

15 of 15 new or added lines in 5 files covered. (100.0%)

11296 of 11613 relevant lines covered (97.27%)

859.97 hits per line