coreui / coreui-pro / 36416557040

96%

main: 94%

push

github

fix(SectionInput): keep the aria-label the page puts on the field (#1463)

The group wrote the ariaLabel option over the element's own aria-label
on construction and again on every setConfig, so a field marked up with
aria-label="Birth date" was announced as "Date input", measured in
Chromium's accessibility tree. A label the page wrote is now left
alone, including one it changes later and on dispose, and the ariaLabel
option only fills in an element that has none or an empty one. The same
holds for fields a DatePicker or DateRangeInput adopts: their own
aria-label wins over floatingLabel, ariaStartLabel and ariaEndLabel, as
it already did for the picker's toggle and cleaner.

The examples on the date input and time input pages now point
aria-labelledby at their visible label. The label next to each field
did not name it before, because a <label for> cannot name a group.

6235 of 6790 branches covered (91.83%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

11281 of 11598 relevant lines covered (97.27%)

857.91 hits per line