hyperledger-labs / fabric-smart-client / 36419883708

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(runner): validate batch capacity and timeout before starting the batcher (#1914)

newBatcher started its batching goroutine without validating its arguments. A zero capacity made start divide by zero, and a non-positive timeout made time.NewTicker panic, both on the background goroutine where the caller cannot recover them, crashing the process. A negative capacity panicked in the caller with an unhelpful makeslice error.

Validate capacity and timeout in newBatcher before the goroutine starts and panic in the caller with a message naming the invalid argument, following the convention of time.NewTicker and keeping the public constructor signatures unchanged. Document the precondition on NewBatchRunner and NewBatchExecutor.

Cover zero and negative capacity and timeout for both constructors.

Fixes #1913

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

11 existing lines in 5 files now uncovered.

27793 of 32132 relevant lines covered (86.5%)

2296.37 hits per line