hyperledger-labs / fabric-smart-client / 36428650090

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(view): return errors instead of panicking from client Initiate paths (#1916)

view: fix CallView error message, trace Initiate, document error paths

- client.go: CallViewWithContext returned "expected initiate view
  response, got nothing" when the missing payload was actually the
  CallView response; fix the copy-pasted message.
- client.go: give the grpc client's Initiate a tracer span, matching
  CallViewWithContext, instead of running untraced.
- client.go, client.go (web), config.go, manager.go: document the new
  error conditions on NewClient, ValidateClientConfig, and
  InitiateViewWithIdentity, and explain why the web client can't
  support Initiate.
- client_api_test.go: cover the CallViewWithContext missing-response
  path, and drop unused receivers/params flagged by revive (enabled on
  main after this branch forked).

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

---------

Signed-off-by: Somesh Mal <malsomesh9@gmail.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Co-authored-by: Somesh Mal <malsomesh9@gmail.com>

Coverage Stats

30 of 34 new or added lines in 4 files covered. (88.24%)

7 existing lines in 4 files now uncovered.

27831 of 32164 relevant lines covered (86.53%)

2348.96 hits per line