hyperledger-labs / fabric-smart-client / 36419643532

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(vfsdk): wrap every view-factory constructor result without IsNil (#1910)

The MakeFunc shim that turns a view-factory constructor into a view-factories group provider tested the returned factory with reflect.Value.IsNil and left nil results unwrapped. IsNil panics for kinds that cannot be nil, so a constructor returning its factory by value, which validateConstructorType accepts, panicked inside the shim. A nil result left unwrapped does not match the shim's declared *factoryEntry return type, so a constructor failing with (nil, err) panicked in reflect.MakeFunc instead of reporting its error.

Wrap the factory unconditionally: factoryEntry.factory is the view.Factory interface, so value, pointer and nil pointer factories are wrapped the same way. When the constructor returns a non-nil error, return it with a zero entry instead, since dig discards the other results of a failed constructor and newEntry rejects the nil view.Factory an interface-typed constructor may return with its error.

Cover a value-typed factory with and without an error return, and failing constructors returning a nil pointer and a nil view.Factory.

Fixes #1909

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

4 of 4 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

27797 of 32128 relevant lines covered (86.52%)

2348.88 hits per line