hyperledger-labs / fabric-smart-client / 36395577099

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): guard the processor registries against concurrent registration (#1908)

processorManager held its registries in plain maps. ProcessByID read
r.processors and r.defaultProcessor while AddProcessor,
SetDefaultProcessor and AddChannelProcessor wrote them, so a registration
overlapping a dispatch could panic with "concurrent map read and map
write". Both sides run concurrently: ProcessByID is reached from the
committer's post-processing, whose event notifiers run on their own
goroutines, and platform/fabric/processor.go exposes registration to
applications at any point in a node's life.

Guard the registries with an RWMutex, taking the write lock in the three
registration methods and resolving processors through read-locked
accessors. Dispatch holds no lock: Processor.Process is application code
and may call back into the manager, so a lock spanning it would deadlock.

Cover both with tests, one dispatching and registering concurrently, one
registering from inside Process. Each dispatch gets its own rwsetfake.RWSet
because the fake counts Done calls without synchronisation.

Fixes #1907

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

23 of 23 new or added lines in 1 file covered. (100.0%)

7 existing lines in 3 files now uncovered.

27789 of 32126 relevant lines covered (86.5%)

2284.95 hits per line