enbility / ship-go / 36413409072

93%

Build Type

push

github

Committed by web-flow

Commit Message

fix(ws): deliver queued SHIP messages before closing the connection (#120)

Callers queue a final SHIP message and close in the same breath:
abortProtocolHandshake sends its "protocol handshake error", the CMI
rejection sends its reply. The message never reached the peer. close()
marks the connection closed first, and the write pump drops anything it
has not written yet; a close with a reason also writes its close frame
directly, overtaking the queue. The conformance tool saw a 1006 (or
4001) close and no abort, failing TC_SHIP_PROT_003-006.

CloseDataConnection now flushes first: it stops accepting new SHIP
messages, asks the write pump to write everything already queued, and
waits for its acknowledgement, at most flushTimeout (2s), before writing
the close frame and closing. The pump is the only writer, so once it
acknowledges no message is held between the queue and the socket. The
flush is skipped when the connection is already closed or was never
started.

A real-socket regression test queues an abort and closes immediately,
with and without a close frame, and asserts the peer receives the abort
before the connection ends. Without the flush it fails on the first run.

Coverage Stats

34 of 36 new or added lines in 1 file covered. (94.44%)

2 existing lines in 1 file now uncovered.

6163 of 6621 relevant lines covered (93.08%)

11522.08 hits per line