enbility / ship-go / 35613403500

93%

push

github

fix(model): wrap protocol handshake error in its SHIP envelope (#118)

SHIP TS 13.4.4.2.1 defines the SME "protocol handshake error" message by
the root tag "messageProtocolHandshakeError", which wraps the error
number. MessageProtocolHandshakeError was declared flat, so aborts went
out as {"error":N}. The conformance test tool asserts the envelope,
which failed TC_SHIP_PROT_003 whenever its abort reached the wire.

- MessageProtocolHandshakeError is now the envelope around
MessageProtocolHandshakeErrorType, like every other SME message type
(MessageProtocolHandshake, ConnectionPinState, ...). On the wire:
{"messageProtocolHandshakeError":[{"error":N}]}.
- abortProtocolHandshake sends the envelope.
- The prot client/server tests decoded the flat shape and only passed
because of it; they now decode the envelope and fail without it.

4 of 4 new or added lines in 1 file covered. (100.0%)

6138 of 6601 relevant lines covered (92.99%)

11277.24 hits per line