enbility / ship-go

93%

Build Type

push

github

Committed by web-flow

Commit Message

Fix pairing issues and trust duplications (#82)

Fixes pairing-flow correctness issues and eliminates duplicate
ServiceDetails entries that were causing already-registered devices to
be rejected.

##  Hub — duplicate service entries
- Introduce mergeOrAddService, a single registry primitive that matches
existing entries by the union of non-empty SKI / Fingerprint / ShipID,
detects cross-identifier conflicts, and folds matches into a canonical
(trust-preferred) entry under muxReg.
- Replaces per-call ad-hoc patching across mDNS, TLS handshake, pairing,
and registration paths.
- foldInto copies missing identifiers, ORs Trusted/AutoAccept, upgrades
PairingType to AddCu if either side has it, and takes IPv4 if missing.
- ServiceForIdentifier* now prefers a trusted match on collision
(defence against split state from persistence rehydration).
- Behavioural change: an identifier conflict in ServeHTTP now closes the
connection (safeClose) instead of silently creating a parallel entry.

##  Pairing — trust transfer on addCu replacement
- Untrust the prior devZ on every successful addCu-request whose
fingerprint differs, regardless of whether the SHIP ID matches.
- Per Pairing TS §4.3.1.b.i and §10.3, the prior
same-vs-different-ShipID branching was suppressing untrust+remove for
same-SHIP-ID cert rotation (SHIP §12.2.1), causing the merge to abort on
fingerprint conflict and trust to never propagate.

##  mDNS — TXT record validation
  - Make TXT key handling RFC 6763 case-insensitive.

##  Misc
- Reduce SHIP Pairing ring buffer from 100 → 10, the spec-recommended
minimum (Pairing TS §11.2).
- Restore activation of addCu Replacement timer in
HandleConnectionClosed — accidentally removed previously.

Coverage Stats

220 of 247 new or added lines in 10 files covered. (89.07%)

7 existing lines in 4 files now uncovered.

5803 of 6243 relevant lines covered (92.95%)

15404.57 hits per line