enbility / ship-go

93%

LAST BUILD ON BRANCH dev

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• auto_accept_stalls_ship
• bug/attempt_reconnect_when_device_reappears
• bug/autoAcceptAnnouncement
• bug/avahi_dead_lock
• bugfix/race-condition
• dev
• feat/dynamicMdnsInterfaceManagement
• feat/hub-bound-port
• feature/action-update
• feature/analysis-docs
• feature/bugfixes
• feature/hub-improvements
• feature/json-parsing-improvements
• feature/maintenance
• feature/mdns-restart-improvements
• feature/register-improvements
• feature/shippairing-2
• feature/tls-improvements
• fix/double-connection-outgoing-dedup
• fix/hub-connection-bugs
• fix/hub_connections_test
• fix/json-whitespace-tolerance
• fix/mdns-service-type-case-sensitivity
• fix/pairing-issues-and-trust-dupes
• fix/pairing-reactivate-listener-on-addCu-removal
• fix/pairing-startup-listener-guard
• fix/pairing-txt-format-validation
• fix/remove-unused-announcement-cancel-ctx
• fix/ship-handshake-conformance
• fix/spine-write-error-teardown
• fix/trusted-reconnect-mdns-drop
• fix_issue_49
• main
• safer-connection-attempt-running-handling
• update-to-zeroconf-v3

Build # 30115025685

Build Type

push

github

Committed by web-flow

Commit Message

fix(mdns): handle service type comparison case-insensitively (#93)

## Problem
`detectServiceType` compares mDNS service types case-sensitively. Some
SHIP
implementations (e.g. Theben Mehrwertmodul) publish on
`_shipPairing._tcp` (camelCase) instead
of `_shippairing._tcp` (lowercase).

While the SHIP spec expects lowercase service types, [RFC 6763
(DNS-Based
Service Discovery)](https://www.rfc-editor.org/rfc/rfc6763.html) states
that
DNS name comparisons — including service type strings — are
case-insensitive.
Because of this, devices using camelCase service types are currently not
detected correctly.

## Solution
Make the service type check in `detectServiceType` case-insensitive, in
line
with RFC 6763, so devices publishing non-lowercase (but otherwise valid)
service types are still correctly recognized.

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

8 existing lines in 3 files now uncovered.

5898 of 6352 relevant lines covered (92.85%)

12390.25 hits per line