enbility / ship-go / 36413688379

93%

Build Type

push

github

Committed by web-flow

Commit Message

fix(hub): don't strand the connection attempt flag when the service is gone (#123)

May fix some failed connection attempts by the living lab after
reregistering SKIs.

coordinateConnectionInitations sets connectionAttemptRunning for a SKI
and raises its attempt counter before it resolves the service entry.
When the entry is gone it returns early — leaving the flag set with no
delay timer attached.

The flag is only ever cleared by the delay timer's callback or by
cancelConnectionDelayTimer, and neither can run without a timer. Every
later call for that SKI then returns at the guard, so the SKI never
initiates a connection again until the process restarts.
UnregisterRemoteService removes the entry concurrently with mDNS
processing, which is exactly how the lookup comes back nil.

The stranded attempt counter has a second effect: it stays raised,
pushing the next delay into the 10–20 s band.

Resolving the service before taking any per-SKI state fixes both. If the
entry is removed after the lookup, the timer already exists and its
callback clears the flag.

Two regression tests: the attempt flag and counter must stay untouched
when no service entry exists, and a SKI must be able to connect again
after an unregister/register cycle.

Coverage Stats

9 of 9 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

6164 of 6626 relevant lines covered (93.03%)

14377.39 hits per line