coreui / coreui-pro / 36405596065

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

fix(SectionInput): expose an invalid or required field to assistive technology (#1460)

The field conveyed its validity by the is-invalid class alone, and its
required option reached only the hidden input, so a screen reader heard
neither a date outside minDate or maxDate nor a required field left
empty. While the field is invalid, the group and every spinbutton
section now carry aria-invalid="true", set together with the class;
otherwise they carry the aria-invalid the page wrote on the element,
which dispose() gives back as it does aria-label and role. With
required, every section carries aria-required="true", which the group
role does not support.

A required field left empty after a validated form is submitted now
stays invalid until it holds a date, where the first blur used to clear
it, as React and Vue already did. A disabled or read-only field is not
reported as missing, since the browser does not validate such controls.

The change adds 128 B gzip to coreui.bundle.js, 158 B to coreui.esm.js
and 111 B to coreui.min.js against v6-dev, measured with gzip-size as
bundlewatch does, which takes the three over their ceilings; each gets
0.25 kB more. coreui.js, coreui.bundle.min.js and coreui.esm.min.js
grow by 128, 112 and 112 B and stay under theirs.

Coverage Stats

6221 of 6776 branches covered (91.81%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

11265 of 11582 relevant lines covered (97.26%)

853.6 hits per line