hyperledger-labs / fabric-smart-client / 36312182522

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): guard the rwset envelope unpacker against a malformed transaction envelope (#1898)

UnpackEnvelopeFromPayloadAndCHHeader (rwset/envelope.go) indexed
tx.Actions[0] and cis.ChaincodeSpec.Input.Args[0], and dereferenced
cis.ChaincodeSpec, cis.ChaincodeSpec.Input, cis.ChaincodeSpec.ChaincodeId
and actionPayload.Action, without checking any of them first.
UnpackEnvelope dereferenced payl.Header the same way. All of this is
peer-supplied data reached from block processing through
Committer.filterUnknownEnvelope, so a single malformed
ENDORSER_TRANSACTION envelope crashed the committer.

The sibling transaction.UnpackEnvelopePayload has the identical shape but
already guards every one of these cases. Port the same guards here,
returning an error instead of panicking.

Cover every malformed shape (nil header, no actions, nil ChaincodeSpec/
Input/ChaincodeId, empty Args, nil Action) with unit tests, and document
the validation UnpackEnvelope/UnpackEnvelopeFromPayloadAndCHHeader now
perform on untrusted input.

Fixes #1896

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

21 of 21 new or added lines in 1 file covered. (100.0%)

8 existing lines in 4 files now uncovered.

27765 of 32100 relevant lines covered (86.5%)

2698.5 hits per line