hyperledger-labs / fabric-smart-client / 36311595292

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabricx): implement NewTransactionFromEnvelopeBytes instead of panicking (#1897)

Manager.NewTransactionFromEnvelopeBytes was a stub that always panicked,
reachable through driver.TransactionManager from
endorser.Builder.NewTransactionFromEnvelopeBytes whenever a fabricx network
receives a raw Fabric envelope instead of an FSC-serialized transaction.

Implement it the same way its sibling NewTransactionFromBytes already does
a few lines up: look up the fixed EndorserTransaction factory (fabricx
never registers any other type), create an empty transaction, and delegate
to Transaction.SetFromEnvelopeBytes, which already exists and is
unit-tested on its own. No new parsing logic is needed.

Replace the panic-assertion test with cases covering the same branches as
NewTransactionFromBytes's test: missing factory, factory creation failure,
and SetFromEnvelopeBytes failure. A full success-path envelope isn't built
in the test, matching the existing TestTransactionSetFromEnvelopeBytes,
which also only exercises the error path.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

11 of 12 new or added lines in 1 file covered. (91.67%)

17 existing lines in 8 files now uncovered.

27733 of 32079 relevant lines covered (86.45%)

2784.54 hits per line