hyperledger-labs / fabric-smart-client / 36309599453

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric/delivery): stop leaking the receiver goroutine and its stream on shutdown (#1894)

runReceiver's stop case was nested inside a select's default branch, so
whenever d.stop and the default case were both ready, select could pick
default and skip closing the current Deliver stream's context, leaking it.
handleBlockResponse also sent to the bounded result channel unconditionally,
so once the reader stopped draining it, that send could block forever and
leak the goroutine along with the stream it never releases. Flatten the
select and race the channel send against d.stop so both paths always tear
down cleanly.

Also drop the delivery service's unused metrics.Provider parameter, merge
the identical DeliverFiltered/DeliverStream interfaces into an alias, and
extract the duplicated Scan/ScanFromBlock body into one helper.

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

57 of 59 new or added lines in 2 files covered. (96.61%)

9 existing lines in 5 files now uncovered.

27726 of 32068 relevant lines covered (86.46%)

2786.45 hits per line